Repository navigation
fix(sdk): error callback should await shard flush on producer shutdown - #3953
Merged
Merged
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3953 +/- ##
=============================================
- Coverage 84.08% 69.97% -14.11%
Complexity 1358 1358
=============================================
Files 1217 1217
Lines 171841 147239 -24602
Branches 139597 114996 -24601
=============================================
- Hits 144484 103024 -41460
- Misses 23428 40241 +16813
- Partials 3929 3974 +45
🚀 New features to boost your workflow:
|
hubcio
requested changes
Aug 25, 2026
github-actions
Bot
added
S-waiting-on-author
haubur
force-pushed
the
fix/producer-shutdown
branch
from
August 25, 2026 15:14
ffd2238 to
f555aa7
Compare
Contributor
Author
|
/ready |
github-actions
Bot
added
S-waiting-on-review
hubcio
approved these changes
Aug 25, 2026
mmodzelewski
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #3947
Rationale
On shutdown() the IggyProducer calls the shutdown() method of the Dispatcher which broadcasts
a termination signal to it's workers. This immediately breaks the loop of the error callback task, which then
does not receive any errors from the final flush anymore.
What changed?
The error callback task does not receive the stop signal anymore. The channel is still open,
and shards can put errors in the queue. On join in shutdown() (after shard tasks are joined) the
error callback is awaited for as long as the queue is emptied.
Local Execution
AI Usage
Test proposed by Claude code.